Ark/bulma
1
0
Fork 0
mirror of https://github.com/jgthms/bulma synced 2026-03-21 20:54:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Remove useless if in js example

Browse Source 
If the length is 0, then the forEach call does nothing anyway

Could we remove the slice part as well ? If IE support is required, can’t we just use Array.prototype.forEach ? Can’t we just remove IE support all together to promote clean and up to date code ? Polyfills and code transpilation are here to help support IE
This commit is contained in:
Jean Lecordier
2022-02-25 00:10:38 +01:00
committed by Jeremy Thomas
parent da784b2071
commit 895b77b3a9
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/documentation/components/navbar.html
View File

@@ -565,9 +565,6 @@ document.addEventListener('DOMContentLoaded', () => {
// Get all "navbar-burger" elements // Get all "navbar-burger" elements
const $navbarBurgers = Array.prototype.slice.call(document.querySelectorAll('.navbar-burger'), 0); const $navbarBurgers = Array.prototype.slice.call(document.querySelectorAll('.navbar-burger'), 0);
// Check if there are any navbar burgers
if ($navbarBurgers.length > 0) {
// Add a click event on each of them // Add a click event on each of them
$navbarBurgers.forEach( el => { $navbarBurgers.forEach( el => {
el.addEventListener('click', () => { el.addEventListener('click', () => {
@@ -582,7 +579,6 @@ document.addEventListener('DOMContentLoaded', () => {
}); });
}); });
}
}); });
{% endcapture %} {% endcapture %}