From 13199b8f51ee4cfb431e783fd83ddb2645215052 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ana=20Mar=C3=ADa=20Mart=C3=ADnez=20G=C3=B3mez?= Date: Wed, 6 Jun 2018 01:45:21 +0200 Subject: [PATCH] Document how to try the changes (#1920) * Document how to try the changes Add to the contributing guide how to rebuild the css and where the documentation to try the documentation changes is. * Remove Bulma dependencies installation form PR template Install Bulma dependencies is not needed to send a PR. * Add how to try your changes to PR templates And after that ask if you tried the changes. --- .github/CONTRIBUTING.md | 11 +++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 11 ++++++----- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index f37b30c3..f154d95a 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -13,6 +13,17 @@ Thanks for helping out! 😇 * Limit the first line to 72 characters or fewer * Reference issues and pull requests liberally +### Try your changes + +When modifying any `.sass`, you will need to rebuild the css. You can do this by running: + +``` +npm install +npm run build +``` + +To see documentation changes check [the documentation readme](docs/README.md). + ### Bulma Sass styleguide * **No semi-colons** `;` or **curly braces** `{` `}` diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 91c9a15b..4a92110f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -16,13 +16,14 @@ This is a **new feature | improvement | bugfix | documentation fix**. ### Testing Done - - - - - + + + + + +